Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xeno Alliance Announcements + Greeno Civil War #3990

Merged
merged 40 commits into from
Jul 28, 2023
Merged

Xeno Alliance Announcements + Greeno Civil War #3990

merged 40 commits into from
Jul 28, 2023

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 25, 2023 •
edited
Loading

About the pull request

Xenos now get messages when their queen set/break alliance to another faction and when other queen set/break alliance with their hive.

Corrupted Xenos with implanted IFF tag now has a choice to defect from the hive and become Renegade (hive allied to USCM) when Queen decides to break alliance with USCM. Xenos that stay loyal to Queen rip the IFF tags out. You have only 10 seconds to make a decision, so think quick. By default xenos stay loyal to Queen.

Renegade Hive is allied to all human factions, but it mostly affects structures and weeds. Renegade ability to attack someone fully depends on its IFF tag settings.

Please check my messages because I'm not very good at writing.

Explain why it's good for the game

More announcements are good because it's less confusing. You know when someone set ally to you and you know when someone is betraying you. It makes sense because allied xenos share announcements anyway. And sudden betrayals are always a bit cheesy.

I think the Renegade addition makes research a little more fun and rewarding. Now, if you implant corrupted xeno with an IFF tag, the xeno player can choose to remain loyal to you if/when the Queen decides to betray. Plus corrupted xenos with the IFF tag are no longer forced to betray, so it's also good. Not sure if that makes sense lore-wise, but since corrupted are artificially created and their DNA is decrypted, it makes at least some sense. Plus we kinda have tamed xenos which work really similarly.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
add: Added announcements for xenos about forming and breaking alliances.
add: Xenos with IFF tag now have a choice to stay loyal to USCM when Queen decides to betray.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 25, 2023
@Drulikar Drulikar marked this pull request as draft July 25, 2023 04:00
@ihatethisengine ihatethisengine marked this pull request as ready for review July 25, 2023 04:27
@ihatethisengine
Copy link
Contributor Author

I decided to limit the renegade feature to corrupted, less checks for normal hive and it makes more sense for corrupted.

@ihatethisengine

This comment was marked as resolved.

Sign in to view
@ihatethisengine
Copy link
Contributor Author

Thinking how to handle renegades' allies. Thinking of three options:

  1. Hardcode ally to all human factions, so renegades won't be able to participate in HvH at all.
  2. Hardcode ally to «good» factions (probably CLF won't have IFF tags outside of events and during an event admins can change alliances how they want)
  3. Actually check IFF tag to decide who renegade can harm and who cannot. Sounds like the best option, but is probably overkill...

So what I did:
Renegade Hive is allied to all humanoids by default. Mostly it affects structures (weeds won't slowdown humans etc.)
Renegade Xeno ability to attack other xenos or humans depends on its IFF tag setting. You cannot attack a xeno that shares at least one IFF tag setting with you. Otherwise you can, even if the xeno is from the same hive. Same with humans. If you somehow lose your IFF tag, you can basically attack anyone. This way renegades are very flexible and we can get pretty cool situations.

@ihatethisengine

This comment was marked as resolved.

Sign in to view
@ihatethisengine

This comment was marked as outdated.

Sign in to view
harryob
harryob requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, should be good

code/modules/mob/living/carbon/xenomorph/xeno_defines.dm Outdated Show resolved Hide resolved
@Drulikar
Copy link
Contributor

Just for future reference:
image

@ihatethisengine
Copy link
Contributor Author

Just for future reference: image

ohhhh was wondering what does this button do lol

ihatethisengine added 3 commits July 28, 2023 11:39
Drulikar
Drulikar approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@harryob harryob added this pull request to the merge queue Jul 28, 2023
Merged via the queue into cmss13-devs:master with commit ce09b07 Jul 28, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Jul 28, 2023
@cm13-github
Automatic changelog for PR #3990 [ci skip]
0301a6f
@Hopekz

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob requested changes

@Drulikar Drulikar Drulikar approved these changes

Assignees
No one assigned
Labels
Feature Feature coder badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ihatethisengine @Drulikar @Hopekz @harryob